-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add OpenStack to External Cloud Providers in quick-start.md #10061
Conversation
Welcome @maxrantil! |
Hi @maxrantil. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@maxrantil: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
56b5016
to
8180943
Compare
8180943
to
7935dc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From CAPO's side I would say this looks good!
/lgtm
LGTM label has been added. Git tree hash: 588a2204f621ef8731020e536c6760a9454f84d5
|
888a3ff
to
82f95db
Compare
72f4828
to
da50980
Compare
ce5222c
to
a46c8ba
Compare
Got a little bit of problems with the git squash, but everything should be in order now. Thanks for the feedback everybody. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 642f09a548a309fcc0208317609b0426eccee188
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold if you want other OpenStack folks to review. Feel free to unhold if you're ok. |
@mdbooth Do you find this looking good too? |
/lgtm |
Provides instructions for users to set up OpenStack as an external cloud provider. Signed-off-by: Max Rantil <max.rantil@est.tech> Co-authored-by: Lennart Jern <lennart.jern@gmail.com> Co-authored-by: Christian Schlotter <chrischdi@users.noreply.github.com>
a46c8ba
to
7371e3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: deff1f1e7b96ef44da33e114f198f8180ceb15a8
|
/hold cancel |
What this PR does / why we need it:
Provides instructions for users to set up OpenStack as an external cloud provider.