-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add PostCreateNamespace hook to E2E tests #10067
🌱 Add PostCreateNamespace hook to E2E tests #10067
Conversation
@@ -168,6 +172,11 @@ func scaleSpec(ctx context.Context, inputGetter func() scaleSpecInput) { | |||
LogFolder: filepath.Join(input.ArtifactFolder, "clusters", input.BootstrapClusterProxy.GetName()), | |||
IgnoreAlreadyExists: true, | |||
}) | |||
|
|||
if input.PostNamespaceCreated != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is the only test that is not using setupSpecNamespace (the reason is explained above; we are pinning namespace name vs creating a name with a random suffix).
NOTE: given that the change is clean, non-breaking, and scoped to the test framework only, it would be nice to backport to the 1.6 branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: be5f65de2fb9fd5254424aebc596245a07982a22
|
a9c9e8c
to
626a37b
Compare
@sbueringer this one should be ready to go now |
Thx! /lgtm |
LGTM label has been added. Git tree hash: 6dca4494913bbde619cd51c56e1d366e770593aa
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add PostCreateNamespace hook to E2E tests * Fix for test who are creating an additional management cluster
* Add PostCreateNamespace hook to E2E tests * Fix for test who are creating an additional management cluster
What this PR does / why we need it:
This PR adds a new PostNamespaceCreated to all E2E tests input objects, thus allowing to inject a function to be run after the test namespace is created. If not specified, this is a no-op.
This can be useful to apply environment settings that apply at the namespace level, eg. setting ResourceQuotas
/area E2E-testing