-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix link to v1alpha4 types #10068
🐛 Fix link to v1alpha4 types #10068
Conversation
@killianmuldoon: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area documentation |
@@ -41,7 +41,7 @@ performed in-place or via Node replacement. | |||
## Proposal | |||
|
|||
This proposal introduces a new API type: Machine. See the full definition in | |||
[machine_types.go](../../api/v1alpha4/machine_types.go). | |||
[machine_types.go](https://github.com/kubernetes-sigs/cluster-api/blob/release-0.4/api/v1alpha4/machine_types.go). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me to link to the same generation of types the proposal was talking about.
Thx! |
Signed-off-by: killianmuldoon <cilliancapi@gmail.com>
8354a56
to
ae5afb4
Compare
/lgtm |
LGTM label has been added. Git tree hash: eb8f5ca38c213d74cf245767d8889dbf2e4bc976
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Fixup a link to v1alpha4 go code in an older proposal.
/area documentations