Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Fix ci-latest test to actually use ci latest #10080

Merged
merged 1 commit into from
Jan 31, 2024
Merged

🌱 Fix ci-latest test to actually use ci latest #10080

merged 1 commit into from
Jan 31, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2024
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-blocking-main
  • /test pull-cluster-api-e2e-conformance-ci-latest-main
  • /test pull-cluster-api-e2e-conformance-main
  • /test pull-cluster-api-e2e-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-upgrade-1-29-1-30-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-blocking-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main

sbueringer
sbueringer commented Jan 31, 2024
View reviewed changes
test/e2e/k8s_conformance_test.go
@@ -41,16 +43,11 @@ var _ = Describe("When testing K8S conformance [Conformance] [K8s-Install]", fun

var _ = Describe("When testing K8S conformance with K8S latest ci [Conformance] [K8s-Install-ci-latest]", func() {
K8SConformanceSpec(ctx, func() K8SConformanceSpecInput {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically I don't have to consider env vars when doing read/write of the version as we don't set KUBERNETES_VERSION_LATEST_CI via env var (just via e2e config). But I think it's better to also support the case where the env var is set

sbueringer
sbueringer commented Jan 31, 2024
View reviewed changes
test/e2e/k8s_conformance_test.go
testSpecificE2EConfig := e2eConfig.DeepCopy()
e2eConfig.Variables["KUBERNETES_VERSION"] = kubernetesVersion

Expect(os.Setenv("KUBERNETES_VERSION", kubernetesVersion)).To(Succeed())
return K8SConformanceSpecInput{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual mistake that lead to us using the wrong version was setting the variable in e2eConfig instead of in testSpecificE2EConfig 😂

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main

@sbueringer
Copy link
Member Author

Let's verify via logs that we are actually using the right versions

@sbueringer
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@chrischdi
Copy link
Member 

failed to create worker DockerMachine: error pulling container image kindest/node:v1.30.0-alpha.0.914_46c9bd12674fa5: failure pulling container image: Error response from daemon: manifest for kindest/node:v1.30.0-alpha.0.914_46c9bd12674fa5 not found: manifest unknown: manifest unknown

I think we are not building the image according to the logs which is why it tries to pull it which of course does not work because it does not exist.

@sbueringer
Copy link
Member Author

sbueringer commented Jan 31, 2024 •
edited

Yup. I think I know why (env var is not set in test infra).

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2024
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main

@sbueringer
Fix ci-latest test to actually use ci latest
d358df9 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main
/test pull-cluster-api-e2e-conformance-main

@sbueringer
Copy link
Member Author

We have to also checkout Kubernetes. We do this in the periodic but not in the presubmit

KUBE_ROOT /home/prow/go/src/k8s.io/kubernetes
/home/prow/go/src/sigs.k8s.io/cluster-api/scripts/ci-e2e-lib.sh: line 140: cd: /home/prow/go/src/k8s.io/kubernetes: No such file or directory
+ EXIT_VALUE=1

Fix PR: kubernetes/test-infra#31781

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-main

@sbueringer
Copy link
Member Author

/hold cancel

All good now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
@chrischdi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b21162a59085d3e73fd4881f9970ac597ece2b43

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0336e78 into kubernetes-sigs:main Jan 31, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 31, 2024
@sbueringer sbueringer deleted the pr-fix-ci-latest branch January 31, 2024 19:05
@chrischdi chrischdi mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbueringer @k8s-ci-robot @chrischdi