-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix ci-latest test to actually use ci latest #10080
🌱 Fix ci-latest test to actually use ci latest #10080
Conversation
/test ? |
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-conformance-ci-latest-main |
@@ -41,16 +43,11 @@ var _ = Describe("When testing K8S conformance [Conformance] [K8s-Install]", fun | |||
|
|||
var _ = Describe("When testing K8S conformance with K8S latest ci [Conformance] [K8s-Install-ci-latest]", func() { | |||
K8SConformanceSpec(ctx, func() K8SConformanceSpecInput { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically I don't have to consider env vars when doing read/write of the version as we don't set KUBERNETES_VERSION_LATEST_CI via env var (just via e2e config). But I think it's better to also support the case where the env var is set
a248292
to
f4c6fcd
Compare
testSpecificE2EConfig := e2eConfig.DeepCopy() | ||
e2eConfig.Variables["KUBERNETES_VERSION"] = kubernetesVersion | ||
|
||
Expect(os.Setenv("KUBERNETES_VERSION", kubernetesVersion)).To(Succeed()) | ||
return K8SConformanceSpecInput{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual mistake that lead to us using the wrong version was setting the variable in e2eConfig instead of in testSpecificE2EConfig 😂
/test pull-cluster-api-e2e-conformance-ci-latest-main |
Let's verify via logs that we are actually using the right versions |
/hold |
I think we are not building the image according to the logs which is why it tries to pull it which of course does not work because it does not exist. |
Yup. I think I know why (env var is not set in test infra). |
f4c6fcd
to
8642409
Compare
/test pull-cluster-api-e2e-conformance-ci-latest-main |
8642409
to
b7c4bc0
Compare
/test pull-cluster-api-e2e-conformance-ci-latest-main |
Signed-off-by: Stefan Büringer buringerst@vmware.com
b7c4bc0
to
d358df9
Compare
/test pull-cluster-api-e2e-conformance-ci-latest-main |
We have to also checkout Kubernetes. We do this in the periodic but not in the presubmit
Fix PR: kubernetes/test-infra#31781 |
/test pull-cluster-api-e2e-conformance-ci-latest-main |
/hold cancel All good now |
/lgtm |
LGTM label has been added. Git tree hash: b21162a59085d3e73fd4881f9970ac597ece2b43
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #