-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃尡 bump golangci-lint
to v1.56.1
#10124
馃尡 bump golangci-lint
to v1.56.1
#10124
Conversation
@adityabhatia There was a .1 release a few minutes ago |
c8327d4
to
d6afeb8
Compare
thanks for the heads up. The |
/retitle 馃尡 bump |
golangci-lint
to v1.56.0golangci-lint
to v1.56.1
/retest-required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
/lgtm
/approve
err = r.updateMachineDeployment(ctx, md, func(*clusterv1.MachineDeployment) { | ||
mdutil.SetDeploymentRevision(md, updatedMS.Annotations[clusterv1.RevisionAnnotation]) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please open a follow-up issue to take a closer look into this. I think it's not the first time I notice it, but the code as is doesn't make much sense. I think there are reasons why it still works but we should investigate a bit and then clean it up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same for l.137)
LGTM label has been added. Git tree hash: 0f688b0b78d7b0a8088cea8f4284ef5651704f94
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10114
/area dependency