🌱 machinedeployment: set revision on machinedeployment and patch via defer #10160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/machinedeployment
chrischdi
changed the title
k8s-ci-robot
added
the
size/M
|
Thank you! /lgtm /assign @fabriziopandini @vincepri |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 33354910467d9c416546f648f06628ad38f26340
|
|
/assign @fabriziopandini :-) |
|
/assign @fabriziopandini |
|
nice cleanup! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a follow-up from: https://github.com/kubernetes-sigs/cluster-api/pull/10124/files#r1484483425
This code recently got changed in this PR: https://github.com/kubernetes-sigs/cluster-api/pull/10124/files#diff-d9a80cabbd6ae2ad7412b4e57a7f3d474b4816a021e4b84987c0895c6b1189c6R117
Before that, when calling
r.updateMachineDeploymentdid never make any sense, because inside the anonymous function we never passed through the variable from the function, but our global machinedeployment instead.So technically we already always used patching using
deferinstead of immediately patching the object.There also seems to be no race when patching in defer, because the annotation gets never read from the machinedeployment. (We read it from machinesets).
cc @sbueringer
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area machinedeployment