Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃尡 add hivelocity infra provider to clusterctl #10168

Merged

Conversation

kranurag7
Copy link
Contributor

What this PR does / why we need it:

  • adds hivelocity infra provider to clusterctl

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10167

/area clusterctl

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Feb 16, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @kranurag7. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2024
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
@kranurag7 kranurag7 force-pushed the kr/add-hivelocity-infra-provider branch from ccef514 to adf7cd2 Compare February 26, 2024 19:36
@fabriziopandini
Copy link
Member

/test pull-cluster-api-test-main

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 28, 2024
@chrischdi
Copy link
Member

/tide merge-method-squash

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d9397120a61d87447564a303c3d553fd146819ad

@kranurag7
Copy link
Contributor Author

/tide merge-method-squash

@chrischdi I think in this case manual squashing is not required from my end. I was thinking of doing it, once the checks are green.

@chrischdi
Copy link
Member

The label adding did not really work, but yeah should not be required :-)

/tide merge-method-squash

@chrischdi chrischdi added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 28, 2024
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@fabriziopandini
Copy link
Member

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 91ad0fd into kubernetes-sigs:main Feb 29, 2024
21 of 23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Feb 29, 2024
@k8s-infra-cherrypick-robot

@fabriziopandini: #10168 failed to apply on top of branch "release-1.6":

Applying: add hivelocity infra provider to clusterctl
Using index info to reconstruct a base tree...
M	cmd/clusterctl/client/config/providers_client.go
M	cmd/clusterctl/client/config_test.go
M	cmd/clusterctl/cmd/config_repositories_test.go
M	docs/book/src/clusterctl/provider-contract.md
M	docs/book/src/reference/glossary.md
M	docs/book/src/reference/providers.md
M	docs/book/src/user/quick-start.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/user/quick-start.md
CONFLICT (content): Merge conflict in docs/book/src/user/quick-start.md
Auto-merging docs/book/src/reference/providers.md
Auto-merging docs/book/src/reference/glossary.md
Auto-merging docs/book/src/clusterctl/provider-contract.md
Auto-merging cmd/clusterctl/cmd/config_repositories_test.go
Auto-merging cmd/clusterctl/client/config_test.go
Auto-merging cmd/clusterctl/client/config/providers_client.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add hivelocity infra provider to clusterctl
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kranurag7 kranurag7 deleted the kr/add-hivelocity-infra-provider branch February 29, 2024 17:17
kranurag7 added a commit to kranurag7/cluster-api that referenced this pull request Feb 29, 2024
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

---------

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
kranurag7 added a commit to kranurag7/cluster-api that referenced this pull request Feb 29, 2024
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
kranurag7 added a commit to kranurag7/cluster-api that referenced this pull request Feb 29, 2024
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
kranurag7 added a commit to kranurag7/cluster-api that referenced this pull request Feb 29, 2024
Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
SubhasmitaSw pushed a commit to SubhasmitaSw/cluster-api that referenced this pull request Mar 15, 2024
* add hivelocity infra provider to clusterctl

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* fix spaces

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* update provider name

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* use updated syntax for naming infra provider

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* address review comments

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

---------

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Dhairya-Arora01 pushed a commit to Dhairya-Arora01/cluster-api that referenced this pull request May 25, 2024
* add hivelocity infra provider to clusterctl

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* fix spaces

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* update provider name

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* use updated syntax for naming infra provider

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* address review comments

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

---------

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Dhairya-Arora01 pushed a commit to Dhairya-Arora01/cluster-api that referenced this pull request May 25, 2024
* add hivelocity infra provider to clusterctl

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* fix spaces

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* update provider name

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* use updated syntax for naming infra provider

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

* address review comments

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>

---------

Signed-off-by: kranurag7 <81210977+kranurag7@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add hivelocity infra provider to clusterctl
6 participants