Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Better verbose logging on override path #10180

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

ryjogo
Copy link
Contributor

@ryjogo ryjogo commented Feb 20, 2024

What this PR does / why we need it:

Aids troubleshooting when dealing with overrides, at least it helped me when looking at #10179

/area clusterctl

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Feb 20, 2024
Copy link

linux-foundation-easycla bot commented Feb 20, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @ryjogo!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 20, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @ryjogo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 20, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 20, 2024
@chrischdi
Copy link
Member

/ok-to-test

Change looks good to me. Could you provide a sample how the log looks like?

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2024
@ryjogo
Copy link
Contributor Author

ryjogo commented Feb 21, 2024

/ok-to-test

Change looks good to me. Could you provide a sample how the log looks like?

Oh, sure:

➜  bin/clusterctl generate cluster capi-test \
    --kubeconfig ~/.kube/kind \
    --config ~/.cluster-api/clusterctltest.yaml \
    --infrastructure vsphere \
    --kubernetes-version v1.29.0 \
    --control-plane-machine-count 1 \
    --worker-machine-count 3 -v5 > /dev/null
    
Using configuration File="/Users/rgo/.cluster-api/clusterctltest.yaml"
Overrides SearchFile="/Users/rgo/.config/cluster-api/overrides/infrastructure-vsphere/v1.9.0/cluster-template.yaml" Provider="infrastructure-vsphere" Version="v1.9.0"
Fetching File="cluster-template.yaml" Provider="vsphere" Type="InfrastructureProvider" Version="v1.9.0"
Using configuration File="/Users/rgo/.cluster-api/clusterctltest.yaml"

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small cahnge for the log message, otherwise looks good and I think it provides great value when one hits the issue of override does not get used 👍

@ryjogo
Copy link
Contributor Author

ryjogo commented Feb 21, 2024

Yeah, that's more descriptive.

@chrischdi
Copy link
Member

Could you please rebase the PR? We should not have merge commits on the PR :-)

When testing, prow automatically rebases before doing testing.

ryjogo and others added 2 commits February 21, 2024 20:13
Co-authored-by: Christian Schlotter <chrischdi@users.noreply.github.com>
@ryjogo
Copy link
Contributor Author

ryjogo commented Feb 21, 2024

Hope that did it... apologies.

@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f837127df0d9af9e6d79acf25eed4086987a7dbe

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 02b8789 into kubernetes-sigs:main Feb 27, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants