Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] 🌱 clusterctl: Add 0 default to worker-machine-count help #10205

Commits on Feb 27, 2024

  1. clusterctl: Add 0 default to worker-machine-count help

    Cobra nicely adds the default value for arguments, except in the case
    where the default is 0 or empty. This causes the help output for
    `clusterctl generate cluster` `--worker-machine-count` to not include
    its default of 0, unlike `--control-plane-machine-count` that has a
    default of 1.
    
    This change explicitly adds the default value to the help text for
    `--worker-machine-count` to make it easier to discover what to expect
    when running the command without this argument.
    
    Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
    stmcginnis authored and k8s-infra-cherrypick-robot committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    da3063b View commit details
    Browse the repository at this point in the history