Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Makefile: bump dependencies #10236

Merged
merged 3 commits into from
Mar 8, 2024
Merged

🌱 Makefile: bump dependencies #10236

merged 3 commits into from
Mar 8, 2024

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Mar 7, 2024 •
edited
Loading

What this PR does / why we need it:

Bumps dependencies in our makefile:

  • setup-envtest
  • conversion-gen: v0.29.0 -> v0.29.2
  • trivy: v0.47.0 -> v0.49.2
  • plantuml: 1.2023.10 -> 1.2024.3
  • openapi-gen

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Mar 7, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 7, 2024
@chrischdi chrischdi added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Mar 7, 2024
@chrischdi
Copy link
Member Author

/area ci

@k8s-ci-robot k8s-ci-robot added area/ci Issues or PRs related to ci and removed do-not-merge/needs-area PR is missing an area label labels Mar 7, 2024
@chrischdi
Copy link
Member Author

/retitle 🌱 Makefile: bump dependencies

@k8s-ci-robot k8s-ci-robot changed the title 🌱 [WIP] Makefile: bump dependencies 🌱 Makefile: bump dependencies Mar 7, 2024
@cahillsf
Copy link
Member

cahillsf commented Mar 7, 2024 •
edited
Loading

looks like we have this issue still open for the kustomize bump: #8457

not sure if its still relevant, trying to see if i can reproduce the issue still off this feature branch

@chrischdi
Copy link
Member Author

looks like we have this issue still open for the kustomize bump: #8457

not sure if its still relevant, trying to see if i can reproduce the issue still off this feature branch

Good point. I removed kustomize from the bump, let's handle that separately.

fabriziopandini
fabriziopandini reviewed Mar 8, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9533c6faf6fd34cf5ffdfdedf1bf3c0f5d1ee50d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 880564a into kubernetes-sigs:main Mar 8, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Mar 8, 2024
@chrischdi chrischdi deleted the pr-bump-makefile-deps branch March 8, 2024 12:20
sbueringer
sbueringer reviewed Mar 12, 2024
View reviewed changes
Makefile
@@ -183,7 +183,7 @@ IMPORT_BOSS_PKG := k8s.io/code-generator/cmd/import-boss
CONVERSION_VERIFIER_BIN := conversion-verifier
CONVERSION_VERIFIER := $(abspath $(TOOLS_BIN_DIR)/$(CONVERSION_VERIFIER_BIN))

OPENAPI_GEN_VER := 5e7f5fd
OPENAPI_GEN_VER := 70dd376
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrischdi Nit: going forward if we touch this again. Would be good to add some comment about this commit (e.g. the date). This would make it a lot easier to figure out how outdated this is

SubhasmitaSw pushed a commit to SubhasmitaSw/cluster-api that referenced this pull request Mar 15, 2024
@chrischdi @SubhasmitaSw
🌱 Makefile: bump dependencies (kubernetes-sigs#10236)
0542266 
* Makefile: bump dependencies

* kube-openapi generator fixes

* regenerate diagrams
Dhairya-Arora01 pushed a commit to Dhairya-Arora01/cluster-api that referenced this pull request May 25, 2024
@chrischdi @Dhairya-Arora01
🌱 Makefile: bump dependencies (kubernetes-sigs#10236)
c54c2ed 
* Makefile: bump dependencies

* kube-openapi generator fixes

* regenerate diagrams
Dhairya-Arora01 pushed a commit to Dhairya-Arora01/cluster-api that referenced this pull request May 25, 2024
@chrischdi @Dhairya-Arora01
🌱 Makefile: bump dependencies (kubernetes-sigs#10236)
e2beceb 
* Makefile: bump dependencies

* kube-openapi generator fixes

* regenerate diagrams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@enxebre enxebre Awaiting requested review from enxebre

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@chrischdi @cahillsf @k8s-ci-robot @sbueringer @fabriziopandini