Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 DumpResourcesForCluster should fail fast for i/o errors #10238

Merged
merged 1 commit into from
Mar 11, 2024
Merged

🌱 DumpResourcesForCluster should fail fast for i/o errors #10238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 14 additions & 0 deletions test/framework/alltypes_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,8 @@ func DumpResourcesForCluster(ctx context.Context, input DumpResourcesForClusterI
for _, resource := range input.Resources {
resourceList := new(unstructured.UnstructuredList)
resourceList.SetGroupVersionKind(resource.GVK)

var i int
var listErr error
_ = wait.PollUntilContextTimeout(ctx, retryableOperationInterval, retryableOperationTimeout, true, func(ctx context.Context) (bool, error) {
if listErr = input.Lister.List(ctx, resourceList, client.InNamespace(resource.Namespace)); listErr != nil {
Expand All @@ -165,6 +167,18 @@ func DumpResourcesForCluster(ctx context.Context, input DumpResourcesForClusterI
if strings.HasSuffix(listErr.Error(), "connect: no route to host") {
return true, nil
}
// e.g This error happens when the API server for the workload cluster is down or the control plane endpoint
// can't be reached from the machine where the E2E test runs.
// NOTE: we consider this error won't recover after it happens at least 3 times in a row
if strings.HasSuffix(listErr.Error(), "i/o timeout") {
i++
if i >= 3 {
return true, nil
}
return false, nil
}

i = 0
return false, nil
}
return true, nil
Expand Down