Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Document the in-memory provider #10268

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Add documentation about the in-memory provider

/area documentation

@k8s-ci-robot k8s-ci-robot added the area/documentation Issues or PRs related to documentation label Mar 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 13, 2024
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

test/infrastructure/inmemory/README.md Outdated Show resolved Hide resolved
test/infrastructure/inmemory/README.md Outdated Show resolved Hide resolved
test/infrastructure/inmemory/README.md Outdated Show resolved Hide resolved
test/infrastructure/inmemory/README.md Outdated Show resolved Hide resolved
test/infrastructure/inmemory/README.md Show resolved Hide resolved
@sbueringer
Copy link
Member

Thx!

Feel free to squash

/lgtm

/assign @chrischdi

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5fdf6b50255a7c670f9329900f5151dded2955be

test/infrastructure/inmemory/README.md Outdated Show resolved Hide resolved
test/infrastructure/inmemory/README.md Outdated Show resolved Hide resolved
test/infrastructure/inmemory/README.md Outdated Show resolved Hide resolved
test/infrastructure/inmemory/README.md Outdated Show resolved Hide resolved
@chrischdi
Copy link
Member

As of that lgtm

Thx for documenting this!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2024
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

@chrischdi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2617cd6293e25fe3eddc78e4dbc038f1c045323

@sbueringer
Copy link
Member

Thx

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4bc7d4b into kubernetes-sigs:main Mar 25, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Mar 25, 2024
@fabriziopandini fabriziopandini deleted the document-in-memory-provider branch March 27, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants