Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add ClusterClass variables metadata #10308

Merged
merged 1 commit into from
Mar 26, 2024
Merged

🌱 Add ClusterClass variables metadata #10308

merged 1 commit into from
Mar 26, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
See issue for details. Would be nice to get this merged this week so it can be easily included in v1.7.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #10023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Mar 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2024
@sbueringer
Copy link
Member Author

sbueringer commented Mar 25, 2024 •
edited
Loading

/assign @fabriziopandini @chrischdi

/cc @richardcase @Danil-Grigorev @JoelSpeed
(@Danil-Grigorev I hope it's okay that I've opened this PR, I would like to get this into v1.7.0 and code freeze is on 2 April)

Danil-Grigorev
Danil-Grigorev approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@Danil-Grigorev Danil-Grigorev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba1d290e89dc061c44b038c5347cc4b54f69bebd

@sbueringer sbueringer added the area/clusterclass Issues or PRs related to clusterclass label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2024
@sbueringer
Add ClusterClass variables metadata
0d6b215 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer sbueringer mentioned this pull request Mar 25, 2024
Closed
@Danil-Grigorev
Copy link
Member

/lgtm
Thanks for jumping on this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 92876ec49186f63bd20cf5001dc523c523002197

@fabriziopandini
Copy link
Member

/lgtm

chrischdi
chrischdi reviewed Mar 26, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold

in case you want others to review too.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@sbueringer
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit c851629 into kubernetes-sigs:main Mar 26, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Mar 26, 2024
@sbueringer sbueringer deleted the pr-cc-variable-metadata branch March 26, 2024 12:41
@sbueringer
Copy link
Member Author

/cherry-pick release-1.6

(based on the experimental feature clause, for quicker adoption)

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 26, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #10320

In response to this:

/cherry-pick release-1.6

(based on the experimental feature clause, for quicker adoption)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi chrischdi mentioned this pull request Mar 28, 2024
Merged
@sbueringer sbueringer mentioned this pull request Apr 16, 2024
Merged
@sbueringer sbueringer mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@richardcase richardcase Awaiting requested review from richardcase

@Danil-Grigorev Danil-Grigorev Awaiting requested review from Danil-Grigorev

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@chrischdi chrischdi

@fabriziopandini fabriziopandini

@Danil-Grigorev Danil-Grigorev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

Provide metadata to ClusterClass variables
6 participants
@sbueringer @k8s-ci-robot @Danil-Grigorev @fabriziopandini @k8s-infra-cherrypick-robot @chrischdi