Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Cluster api manifesto #10329

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Taking inspiration from Tim Hockin’s talk at KubeCon NA 2023, also for
Cluster API project is important to define the long term vision, the manifesto of “where we are going” and “why”.

/area documentation

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 27, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 27, 2024
@dlipovetsky
Copy link
Contributor

+1

Thanks for this, @fabriziopandini.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d9ce8ac3b5ad3931cc9e10a397651b3b3805baea

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some minor nits.
+1 to have such a page.

docs/book/src/user/manifesto.md Outdated Show resolved Hide resolved
docs/book/src/user/manifesto.md Show resolved Hide resolved
docs/book/src/user/manifesto.md Outdated Show resolved Hide resolved
docs/book/src/user/manifesto.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

for more folks to check maybe

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 28, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ba8f822350fddd88ca736c0652f297deaf1dc6c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@enxebre
Copy link
Member

enxebre commented Mar 29, 2024

/lgtm

@g-gaston
Copy link
Contributor

/lgtm

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks for working on this!

/lgtm

@killianmuldoon
Copy link
Contributor

We should backport to release-1.7 to get this in the main version of the book.

/cherry-pick release-1.7

@k8s-infra-cherrypick-robot

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

We should backport to release-1.7 to get this in the main version of the book.

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit c0a1816 into kubernetes-sigs:main Apr 2, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Apr 2, 2024
@k8s-infra-cherrypick-robot

@killianmuldoon: cannot checkout release-1.7: error checking out "release-1.7": exit status 1 error: pathspec 'release-1.7' did not match any file(s) known to git

In response to this:

We should backport to release-1.7 to get this in the main version of the book.

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

sbueringer commented Apr 3, 2024

Would have been nice to give folks more than just 2-3 business days to review this PR. I think the intention from Fabrizio was to get broad community consensus on this doc (and therefore keep it open for a bit).

That being said. If folks have feedback, please still comment on the PR and we'll follow-up.

@sbueringer
Copy link
Member

Thx for driving this!

/lgtm

@AndiDog
Copy link
Contributor

AndiDog commented Apr 9, 2024

I guess this should appear at https://cluster-api.sigs.k8s.io/user/manifesto or at least the first page of the book. Is there a deployment problem for the book website?

(Scratch that, I saw the above comment of requiring a cherrypick.)

@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.7

@killianmuldoon
Copy link
Contributor

@AndiDog thanks for the reminder 😅 - branch should exist now

@k8s-infra-cherrypick-robot

@killianmuldoon: #10329 failed to apply on top of branch "release-1.7":

Applying: Cluster API manifesto
.git/rebase-apply/patch:96: trailing whitespace.
Those two requests from Cluster API’s users are two sides of the same coin, a reminder that Cluster API must 
.git/rebase-apply/patch:143: trailing whitespace.
will be the venue where common guidelines are discussed and documented, as well as the place of choice where common 
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	docs/book/src/SUMMARY.md
Falling back to patching base and 3-way merge...
CONFLICT (add/add): Merge conflict in docs/book/src/user/manifesto.md
Auto-merging docs/book/src/user/manifesto.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Cluster API manifesto
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor

Needs to be done manually

@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@killianmuldoon: new pull request created: #10404

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member

Needs to be done manually

It is already in release-1.7 :-)

@fabriziopandini fabriziopandini deleted the cluster-api-manifesto branch April 18, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet