Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Document the triage process #10367

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Writing down some practices / lesson learned from bug triage /backlog grooming sessions

/area documentation

/hold
For discussion in the office hours + give time to folks to review

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 3, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 3, 2024
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks @fabriziopandini , i just had a basic question and a couple nits.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 4, 2024
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found some typos.

the process SGTM. i think there are 3 important labels that should always be on tickets.

  • kind
  • priority
  • area

milestone can also be used for planning and triage.
but i see CAPI doesn't use milestones (any more)

is needs-triage going away too?

one problem with this triage process without milestone or needs-triage would be filtering of tickets that needs triage, it would need a negating query based on priority e.g.

is:issue is:open -label:priority/critical-urgent -label:priority/important-soon -label:priority/important-longterm -label:priority/backlog -label:priorty/awaiting-more-evidence 

for kubeadm, since we use milestone it could be just:

is:open is:issue no:milestone

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini changed the title 📖 Document the triage process [Do not review] 📖 Document the triage process Apr 4, 2024
@fabriziopandini
Copy link
Member Author

@fabriziopandini fabriziopandini force-pushed the document-triage-process branch 2 times, most recently from 5148e97 to 4219f6c Compare April 10, 2024 16:40
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content looks great here, my comments are all minor grammar nits.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

sbueringer commented Apr 11, 2024

Let me know when it's ready for review (just saying in case you forgot to remove "do not review")

@fabriziopandini fabriziopandini changed the title [Do not review] 📖 Document the triage process 📖 Document the triage process Apr 11, 2024
@fabriziopandini
Copy link
Member Author

@sbueringer PTAL at your convenience

Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit, otherwise lgtm

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall makes sense to me! just a few nits

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

/hold
(whenever you want to merge)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: dac01833195387d354eb48d112efc38e8d373fa1

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@fabriziopandini
Copy link
Member Author

/hold cancel
we discussed this in the office hours in the last two meetings, no objections raised
All comments on the PR are addressed, let's move on

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit ec900f8 into kubernetes-sigs:main Apr 17, 2024
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 17, 2024
@fabriziopandini fabriziopandini deleted the document-triage-process branch April 18, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants