🌱 Webhooks: make MDT.replicas and autoscaler mut. exclusive #10370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/area clusterclass |
k8s-ci-robot
added
area/clusterclass
neolit123
changed the title
neolit123
force-pushed
the
1.7-add-mutex-for-autoscaler-and-replicas
branch
from
01f466e
to
7bca522
Compare
|
/cc @sbueringer |
|
Thx! |
sbueringer
reviewed
Apr 9, 2024
elmiko
reviewed
Apr 9, 2024
There was a problem hiding this comment.
aside from @sbueringer 's questions, i think the logic makes sense to me.
neolit123
force-pushed
the
1.7-add-mutex-for-autoscaler-and-replicas
branch
from
7bca522
to
1edc35d
Compare
sbueringer
reviewed
Apr 10, 2024
Add new validation functions in cluster.go and clusterclass.go: - ValidateAutoscalerAnnotationsForCluster - ValidateAutoscalerAnnotationsForClusterClass ..ForCluster is called from validateTopology(). It makes sure that a given Topology does not contain MachineDeploymentToplogy objects under Workers, that have both a "replicas" field set to non-nil and an autoscaler min/max annotation present. Also optionally it checks if there are annotations that are set on the ClusterClass's MachineDeploymentClass for this MachineDeploymentTopology. ..ForClusterClass accepts a list of Clusters that use a certain ClusterClass. Inline, it uses the ..ForCluster function and the same validation as above is performed. It is called from validate() for a CC on update. Additionally: - Add a new builder utility function MachineDeploymentTopologyBuilder#WithAnnotations(). - Add 100% test coverage for the new validation functions.
neolit123
force-pushed
the
1.7-add-mutex-for-autoscaler-and-replicas
branch
from
1edc35d
to
e035135
Compare
|
Thx! /lgtm /assign @fabriziopandini @chrischdi |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: bc7169f6b5a5bef7f002b70c0d29f224c1e3aa91
|
chrischdi
reviewed
Apr 12, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sbueringer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add new validation functions in cluster.go
and clusterclass.go:
..ForCluster is called from validateTopology().
It makes sure that a given Topology does not contain
MachineDeploymentToplogy objects under Workers, that have
both a "replicas" field set to non-nil and autoscaler
min/max annotations present.
Also optionally it checks if there are annotations that are set
on the ClusterClass's MachineDeploymentClass for this
MachineDeploymentTopology.
..ForClusterClass accepts a list of Clusters that use
a certain ClusterClass. Inline, it uses the ..ForCluster
function and the same validation as above is performed.
It is called from validate() for a CC on update.
Additionally:
MachineDeploymentTopologyBuilder#WithAnnotations().
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #10343