Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Document MachinePool feature flag promotion #10371

Merged
merged 1 commit into from
Apr 4, 2024
Merged

📖 Document MachinePool feature flag promotion #10371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/book/src/developer/providers/migrations/v1.6-to-v1.7.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,11 @@ maintainers of providers and consumers of our Go API.
* Patch helper now return error with enough error context (https://github.com/kubernetes-sigs/cluster-api/pull/9946). It is recommended to remove redundant error context on call sites if applicable.

### Suggested changes for providers

* [MachinePools are now enabled by default](https://github.com/kubernetes-sigs/cluster-api/pull/10141) and the feature flag is marked as `beta` instead of `alpha`. If you are re-defining feature flags in your codebase, these values will need to be updated accordingly. If not, the following error will result:

```
panic: feature gate "MachinePool" with different spec already exists: {true false BETA}
```

See [this change](https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4897/files#diff-bd8758c39c0deb35ee6c5c387594f6575580918777fbf2926f5762c7c9fce755L104) for how to update the flag.