-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add MachinePools to ClusterClass Documentation #10418
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit
docs/proposals/20210526-cluster-class-and-managed-topologies.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits :-)
docs/proposals/20210526-cluster-class-and-managed-topologies.md
Outdated
Show resolved
Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md
Outdated
Show resolved
Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md
Outdated
Show resolved
Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md
Outdated
Show resolved
Hide resolved
d524075
to
1896234
Compare
1896234
to
3f82704
Compare
/lgtm /assign @fabriziopandini @chrischdi |
LGTM label has been added. Git tree hash: 9e41c3a872131058495d261330e41814c5ca5af0
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.7 |
@sbueringer: new pull request created: #10448 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR adds relevant documentation for added MachinePool workers support in ClusterClass.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes part of #10028
/area documentation
/area clusterclass