Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add triage-party for the Cluster API backlog #10437

Merged
merged 4 commits into from
May 7, 2024
Merged

🌱 Add triage-party for the Cluster API backlog #10437

merged 4 commits into from
May 7, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Add triage party for Cluster API

/area dev-tools

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/dev-tools cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
Add triage party for Cluster API

/area dev-tools

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 15, 2024
@fabriziopandini
Copy link
Member Author

/area devtools

@k8s-ci-robot k8s-ci-robot added area/devtools Issues or PRs related to devtools and removed do-not-merge/needs-area PR is missing an area label labels Apr 15, 2024
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 19, 2024
@fabriziopandini fabriziopandini changed the title [WIP] 🌱 Add triage-party for the Cluster API backlog 🌱 Add triage-party for the Cluster API backlog Apr 30, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
@fabriziopandini
Copy link
Member Author

I'm using this since two weeks now, and I think it is already a good starting point we can merge now + eventually improve iteratively.
So, removing WIP to get some feedback

sbueringer
sbueringer reviewed May 2, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for opening this PR!

Mostly nits

hack/triage/.gitignore Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
hack/triage/config.yaml Outdated Show resolved Hide resolved
hack/triage/config.yaml Outdated Show resolved Hide resolved
hack/triage/config.yaml Outdated Show resolved Hide resolved
hack/triage/config.yaml Outdated Show resolved Hide resolved
hack/triage/config.yaml Outdated Show resolved Hide resolved
hack/triage/config.yaml Outdated Show resolved Hide resolved
hack/triage/config.yaml Outdated Show resolved Hide resolved
chrischdi
chrischdi reviewed May 3, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single and optional nit, otherwise lgtm

/lgtm

hack/triage/config.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d4d1ec7b654d476d2e74ef4c958d26755c1d523d

@sbueringer
Copy link
Member

Delta looks good so far

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2024
@sbueringer
Copy link
Member

sbueringer commented May 7, 2024 •
edited
Loading

/lgtm
/approve

/hold

Up to you if you want to wait for the test-infra PR or do a follow-up PR after the test-infra PR merges.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3c025602877bf37fd87f9073eb2ac3b28cbfb582

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
@fabriziopandini
Copy link
Member Author

/hold cancel
the test infra PR is taking some time...

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2024
@k8s-ci-robot k8s-ci-robot merged commit cbd1f23 into kubernetes-sigs:main May 7, 2024
21 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone May 7, 2024
@fabriziopandini fabriziopandini deleted the triage-party branch May 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@enxebre enxebre Awaiting requested review from enxebre

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/devtools Issues or PRs related to devtools cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziopandini @k8s-ci-robot @sbueringer @chrischdi