Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Replace exec kubectl with client CreateOrUpdate #10442

Merged
merged 1 commit into from
Jul 2, 2024
Merged

🌱 Replace exec kubectl with client CreateOrUpdate #10442

merged 1 commit into from
Jul 2, 2024

Conversation

cahillsf
Copy link
Member

@cahillsf cahillsf commented Apr 16, 2024 •
edited
Loading

Which issue(s) this PR fixes:
Fixes #9696

/area ci

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2024
@cahillsf cahillsf changed the title WIP replace exec with client create 🌱 WIP replace exec with client create Apr 16, 2024
@cahillsf
Copy link
Member Author

/test help

@k8s-ci-robot
Copy link
Contributor

@cahillsf: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-blocking-main
  • /test pull-cluster-api-e2e-conformance-ci-latest-main
  • /test pull-cluster-api-e2e-conformance-main
  • /test pull-cluster-api-e2e-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-upgrade-1-30-1-31-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-blocking-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cahillsf
Copy link
Member Author

/test pull-cluster-api-build-main

@cahillsf
Copy link
Member Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 7, 2024
@cahillsf
Copy link
Member Author

/test pull-cluster-api-e2e-main

@cahillsf
Copy link
Member Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2024
@cahillsf
Copy link
Member Author

cahillsf commented Jun 3, 2024

/test pull-cluster-api-e2e-main

@cahillsf cahillsf changed the title 🌱 WIP replace exec with client create 🌱 replace exec with client create/update Jun 4, 2024
@cahillsf cahillsf marked this pull request as ready for review June 4, 2024 01:00
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2024
chrischdi
chrischdi reviewed Jun 5, 2024
View reviewed changes
test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
test/framework/clusterctl/clusterctl_helpers.go Outdated Show resolved Hide resolved
test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

@cahillsf I'll take a look soon. Just slowly working through my PR review backlog. But it's getting shorter

@cahillsf
Copy link
Member Author

@cahillsf I'll take a look soon. Just slowly working through my PR review backlog. But it's getting shorter

oh yeah no worries! thanks 😄

chrischdi
chrischdi reviewed Jun 18, 2024
View reviewed changes
test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
test/e2e/kcp_adoption.go Outdated Show resolved Hide resolved
@chrischdi
Copy link
Member

Sorry for the long delay, I think after this 👍

@cahillsf cahillsf force-pushed the replace-exec branch 2 times, most recently from aac88de to c58ad7d Compare June 20, 2024 14:05
@cahillsf
Copy link
Member Author

/test pull-cluster-api-e2e-main

@cahillsf
Copy link
Member Author

@chrischdi thanks for the feedback, i think all the comments have been addressed when you have a chance to take another pass

chrischdi
chrischdi reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d90f65c9e591b6b569d959adf930f4e4f63e9733

sbueringer
sbueringer reviewed Jul 1, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay. Just a few smaller findings, otherwise happy to merge

test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
test/framework/cluster_proxy.go Outdated Show resolved Hide resolved
test/framework/cluster_proxy.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2024
@chrischdi
Copy link
Member

/test pull-cluster-api-e2e-main

@sbueringer sbueringer changed the title 🌱 replace exec with client create/update 🌱 Replace exec kubectl with client CreateOrUpdate Jul 2, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a858b50db111f1e77503deaef68849b6b0f4ca35

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit fd94039 into kubernetes-sigs:main Jul 2, 2024
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@richardcase richardcase Awaiting requested review from richardcase

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@chrischdi chrischdi Awaiting requested review from chrischdi

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

Replace kubectl apply in e2e test framework
4 participants
@cahillsf @k8s-ci-robot @chrischdi @sbueringer