-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Update docs for ClusterResourceSets #10443
📖 Update docs for ClusterResourceSets #10443
Conversation
docs/book/src/tasks/experimental-features/cluster-resource-set.md
Outdated
Show resolved
Hide resolved
ae97d6e
to
d2b79c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think these instructions make sense to me, i have a minor suggestion
docs/book/src/tasks/experimental-features/cluster-resource-set.md
Outdated
Show resolved
Hide resolved
The current documentation links to the original enhancement proposal for examples, but these examples are for an older API version. This commit adds examples directly in the book for the latest API version. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
d2b79c9
to
1475d8b
Compare
/lgtm |
LGTM label has been added. Git tree hash: 62d057bf38943e2768edbb4ff55ffe998fecdf57
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm++
/assign @oscr |
Thank you very much! /approve /cherry-pick release-1.7 |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer: new pull request created: #10491 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The current documentation links to the original enhancement proposal for examples, but these examples are for an older API version. This commit adds examples directly in the book for the latest API version.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area clusterresourceset