Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Update docs for ClusterResourceSets #10443

Merged
merged 1 commit into from
Apr 23, 2024
Merged

📖 Update docs for ClusterResourceSets #10443

merged 1 commit into from
Apr 23, 2024

Conversation

lentzi90
Copy link
Contributor

What this PR does / why we need it:

The current documentation links to the original enhancement proposal for examples, but these examples are for an older API version. This commit adds examples directly in the book for the latest API version.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area clusterresourceset

@k8s-ci-robot k8s-ci-robot added area/clusterresourceset Issues or PRs related to clusterresourcesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 16, 2024
elmiko
elmiko reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think these instructions make sense to me, i have a minor suggestion

docs/book/src/tasks/experimental-features/cluster-resource-set.md Outdated Show resolved Hide resolved
@lentzi90
Update docs for ClusterResourceSets
1475d8b 
The current documentation links to the original enhancement proposal for
examples, but these examples are for an older API version. This commit
adds examples directly in the book for the latest API version.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@elmiko
Copy link
Contributor

elmiko commented Apr 19, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 62d057bf38943e2768edbb4ff55ffe998fecdf57

mboersma
mboersma reviewed Apr 22, 2024
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm++

@lentzi90
Copy link
Contributor Author

/assign @oscr

@sbueringer
Copy link
Member

Thank you very much!

/approve

/cherry-pick release-1.7

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

Thank you very much!

/approve

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Apr 23, 2024
@k8s-ci-robot k8s-ci-robot merged commit 858a870 into kubernetes-sigs:main Apr 23, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 23, 2024
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #10491

In response to this:

Thank you very much!

/approve

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 23, 2024
Merged
@lentzi90 lentzi90 deleted the lentzi90/crs-docs-update branch April 24, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma requested changes

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@elmiko elmiko Awaiting requested review from elmiko

Assignees

@elmiko elmiko

@oscr oscr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterresourceset Issues or PRs related to clusterresourcesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lentzi90 @elmiko @k8s-ci-robot @sbueringer @k8s-infra-cherrypick-robot @mboersma @oscr