-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add Tinkerbell to the providers list #10487
Conversation
/retest-failed |
/retest |
/area clusterctl |
Q: by a quick at the provider web site the latest supported version is K8s 1.22, which is well under support. |
I think the docs are outdated. I am currently using this provider like this:
I would like to have the ability to deploy this with the Helm chart from https://github.com/kubernetes-sigs/cluster-api-operator and avoid using custom manifests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: c10882e2c6220c5c9139beedec3d708c411a53e1
|
/lgtm |
Thx! /approve |
/cherry-pick release-1.7 To make it usable soon'ish. |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@oprinmarius There was another very similar PR that just merged (for another provider). Can you please rebase this PR onto latest main? |
@sbueringer I rebased with latest main, can you please /approve and /lgtm again . Labels were removed. I noticed this test is flaky https://github.com/kubernetes-sigs/cluster-api/actions/runs/8833373455/job/24252531701?pr=10487 /retest |
Yup, that link is really flaky /lgtm |
LGTM label has been added. Git tree hash: 72e46ee9da199c76a2d78ad85e021c73847356a5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jackfrancis Sorry I know that's really a pretty random request :D. Do you think there's any way that that link can be made more stable? 😂 ("https://azure.microsoft.com/en-us/products/kubernetes-service") It fails relatively regularly with our markdown linkchecker. We could also just simply put it on the ignore list to skip verifying it every time. |
@sbueringer: new pull request created: #10516 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10486
/area clusterctl