Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Update CAPI support and guarantees for v1.8 #10529

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

chandankumar4
Copy link
Contributor

What this PR does / why we need it:

This PR updates the supported versions for the next release cycle (1.8).

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes Task: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/release/release-tasks.md#update-supported-versions

@kubernetes-sigs/cluster-api-release-team

/area documentation

Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @chandankumar4. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

sbueringer commented Apr 29, 2024

This has overlap with @fabriziopandini's PR (#10531)

@sbueringer
Copy link
Member

Okay I think it's easier to rebase if we merge this one first

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 11a2659a3b276daf381a744b4dc64e0dde07c30e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9a94459 into kubernetes-sigs:main Apr 29, 2024
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Apr 29, 2024
@fabriziopandini
Copy link
Member

@sbueringer ok to rebase my PR, but we should find a way to set EOL for 1.5 in the current version of the book without cherry-picking the new 1.8 columns that should exist only on main

@chandankumar4 chandankumar4 deleted the support-1.8 branch April 29, 2024 14:29
@sbueringer
Copy link
Member

Let's open a manual cherry-pick once your PR merges

@fabriziopandini
Copy link
Member

The two PR are orthogonal now
@chandankumar4 could you cherry-pick your PR to 1.7 (without the 1.8 column)?

@sbueringer
Copy link
Member

@fabriziopandini Which part of this PR? Dropping the v1.4 column in the versions table? If I see correctly everything else shouldn't be cherry-picked

@fabriziopandini
Copy link
Member

Yes, I think it makes sense to backport everything in this PR except for the 1.8 column

@sbueringer
Copy link
Member

sbueringer commented Apr 29, 2024

I'll open the PR (just to avoid confusion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants