Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Ensure resourceVersions are stable #10530

Merged
merged 1 commit into from
May 2, 2024
Merged

🌱 Ensure resourceVersions are stable #10530

merged 1 commit into from
May 2, 2024

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Apr 29, 2024 •
edited

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
This PR ensures resourceVersions are stable after the quick start tests.

The goal is to detect if some of our controllers are continuously reconcililng objects (and bumping resource versions)

Related: kubernetes/kubernetes#124605

I'll open a corresponding CAPI issue to track the k/k issue soon.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Helps to mitigate #10533

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 29, 2024
@sbueringer sbueringer changed the title 🌱 Ensure resourceVersions are stable [WIP] 🌱 Ensure resourceVersions are stable Apr 29, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2024
@sbueringer sbueringer added the area/e2e-testing Issues or PRs related to e2e testing label Apr 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Apr 29, 2024
@sbueringer sbueringer changed the title [WIP] 🌱 Ensure resourceVersions are stable 🌱 Ensure resourceVersions are stable Apr 29, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2024
@sbueringer
Copy link
Member Author

sbueringer commented Apr 29, 2024 •
edited

Tested locally and it works. Might need some fine-tuning after merge though

@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-blocking-main
  • /test pull-cluster-api-e2e-conformance-ci-latest-main
  • /test pull-cluster-api-e2e-conformance-main
  • /test pull-cluster-api-e2e-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-upgrade-1-30-1-31-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-blocking-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main

@sbueringer
Ensure resourceVersions are stable
bdd8ba2 
Signed-off-by: Stefan Büringer buringerst@vmware.com
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main

This was referenced Apr 29, 2024
Closed
Open
@fabriziopandini
Copy link
Member

Nice!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cc0ec5ff44e8758b0813edf77e735e955ceda3b8

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-main
/test pull-cluster-api-e2e-mink8s-main

(one more time to verify how stable it is)

chrischdi
chrischdi reviewed May 2, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@sbueringer
Copy link
Member Author

/cherry-pick release-1.7

So this can be used to extend test coverage in providers

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

So this can be used to extend test coverage in providers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit dec46d0 into kubernetes-sigs:main May 2, 2024
27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone May 2, 2024
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #10548

In response to this:

/cherry-pick release-1.7

So this can be used to extend test coverage in providers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 2, 2024
Merged
@sbueringer sbueringer deleted the pr-rv-stable branch May 2, 2024 09:26
@sbueringer sbueringer mentioned this pull request May 2, 2024
Closed
19 tasks
This was referenced May 6, 2024
Merged
Merged
@sbueringer sbueringer mentioned this pull request May 13, 2024
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@elmiko elmiko Awaiting requested review from elmiko

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sbueringer @k8s-ci-robot @fabriziopandini @k8s-infra-cherrypick-robot @chrischdi