🌱 Allow users to specify webhook server cert and key names #10551
Conversation
|
|
k8s-ci-robot
added
size/S
|
/check-cla |
1 similar comment
|
/check-cla |
| @@ -218,6 +220,12 @@ func InitFlags(fs *pflag.FlagSet) { | |||
| fs.StringVar(&webhookCertDir, "webhook-cert-dir", "/tmp/k8s-webhook-server/serving-certs/", | |||
| "Webhook cert dir, only used when webhook-port is specified.") | |||
|
|
|||
| fs.StringVar(&webhookCertName, "webhook-cert-name", "tls.crt", | |||
There was a problem hiding this comment.
should we do this for all our controllers to keep it consistent (bootstrap & control-plane)?
There was a problem hiding this comment.
yeah once I fix my CLA I'll take care of this
There was a problem hiding this comment.
Might be worth putting it in a reusable util if we can come up with a reasonable name for it :)
There was a problem hiding this comment.
I might tackle this separately, all of these flags could be defined either in a util here in CAPI, or in a util package in controller runtime, to have the flags consistent across controllers
There was a problem hiding this comment.
or in a util package in controller runtime, to have the flags consistent across controllers
Comes dangerously close to a config file :) (but yeah agree)
|
/check-cla |
|
/easycla |
k8s-ci-robot
added
cncf-cla: yes
vincepri
force-pushed
the
tls-cert-key-flags
branch
from
7ca4bf8 to
4a3cf1e
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: edb88361225082d8b64faa20b1251315341eadb2
|
vincepri
force-pushed
the
tls-cert-key-flags
branch
from
4a3cf1e to
27578d5
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/L
vincepri
force-pushed
the
tls-cert-key-flags
branch
2 times, most recently
from
31a29f9 to
77a4e63
Compare
|
@vincepri Last one, I think: #10551 (comment) |
Signed-off-by: Vince Prignano <vince@prigna.com>
vincepri
force-pushed
the
tls-cert-key-flags
branch
from
77a4e63 to
09bdfb9
Compare
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 84b5f1c326d197e3d064f36bbe6b3c45108ec010
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.7 |
|
/cherry-pick release-1.6 |
|
@vincepri: new pull request created: #10581 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@vincepri: new pull request created: #10582 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area api