🌱 Allow control plane count to be configurable in clusterctl upgrade test. #10584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/testing
willie-yao
commented
May 9, 2024
|
cc @sbueringer. Had to create this fix as a follow-up to #10498 |
willie-yao
force-pushed
the
clusterctl-upgrade-cpcount
branch
from
74dcfd5
to
db89010
Compare
sbueringer
reviewed
May 10, 2024
willie-yao
force-pushed
the
clusterctl-upgrade-cpcount
branch
from
db89010
to
4c6f899
Compare
k8s-ci-robot
added
size/M
willie-yao
force-pushed
the
clusterctl-upgrade-cpcount
branch
from
17eadf7
to
d0c419d
Compare
|
/test pull-cluster-api-e2e-main |
|
Thx! /lgtm Feel free to cherry-pick |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1a65fb3adbd88ca69acb807f9d1fa3c0cb4d98b5
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Thanks! I'll create manual cherry-picks since these changes are across two PRs. I'll incorporate #10498 into the cherry-picks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently, the clusterctl upgrade test hard-codes the controlPlaneMachineCount to 1. There are some scenarios, such as CAPZ's managed cluster, that create a cluster without a control plane machine. This PR will add a fix to add support for those scenarios.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area testing