🌱 Propagate timeout fields from MachineSet to Machine during Machine deletion

[davidvossel]

Fixes #10588
/area machine

What this PR does / why we need it:

Machine's default to nodeDrainTimeout: 0s, which blocks indefinitely if a pod can't be evicted. We can't change the nodeDrainTimeout in-place from the MachineDeployment or MachineSet after a machine is marked for deletion.

This results in a machine that wedged forever but can't be updated using the top level objects that own the machine.

To fix this, this PR allows fields related to machine deletion to be updated in place even when the machine is marked for deletion.

NOTE - I did not add unit tests yet for this PR. I want confirmation this is an acceptable approve before investing time into testing.

[enxebre]

Thanks @davidvossel change makes sense to me. Smoother deletion is actually one of the supporting use cases for inplace propagation. Let's include some unit tests.

See related #5880
#9285

[davidvossel]

Let's include some unit tests.

@enxebre i extended the existing unit test to cover the case of updating a deleting machine.

[enxebre]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 44936fae936d0eab3c39b86c432c24c5e199979d

[enxebre]

/lgtm
/assign @sbueringer

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a7820897401d291e168e73cfc2ea745d5f2c8d87

[sbueringer]

All good from my side. I would open a follow-up issue once this PR is merged to track further work to get this behavior across all MD workflows (e.g. MD rollout, deletion).

/approve

/hold
In case someone else wants to take a look (@fabriziopandini @chrischdi @vincepri)

Otherwise let's merge in a few days

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincepri]

/lgtm

[chrischdi]

Could we update the PR title to more reflect what is happening?

E.g.

🌱 Allow inplace update of fields related to deletion during MachineSet scale to 0

(as of that lgtm)

[sbueringer]

I renamed slightly differently. The scenarios are not distinct and this is also part of fixing the other cases

[sbueringer]

Thx folks!

/hold cancel

I'll open the follow-up issue tomorrow

[sbueringer]

Thx folks!

/hold cancel

I'll open the follow-up issue tomorrow

Here's the follow-up issue: #10753