🐛 Ensure all ownerRef assertions for some Kind are evaluated

[dlipovetsky]

What this PR does / why we need it:
The assertFuncs are passed as a list*. Previously, if two assertFuncs were defined for the same Kind, the assertFunc that appeared later in the list would overwrite the one that appeared earlier.

If someone introduced a second assertFunc for a given Kind, they would receive no signal that the first assertFunc was overwritten. A test relying on the first assertion would give a false positive.

With this change, if two or more assertFuncs are defined for the same Kind, both are evaluated.

* Example:

cluster-api/test/e2e/quick_start_test.go

Lines 44 to 49 in 99866da

	framework.CoreOwnerReferenceAssertion,
	framework.ExpOwnerReferenceAssertions,
	framework.DockerInfraOwnerReferenceAssertions,
	framework.KubeadmBootstrapOwnerReferenceAssertions,
	framework.KubeadmControlPlaneOwnerReferenceAssertions,
	framework.KubernetesReferenceAssertions,

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area e2e-testing

[enxebre]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: f5c3cea91b7fbd6c514ec7120a2f3c549bce81b9

[chrischdi]

/approve

[chrischdi]

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chrischdi]

/cherry-pick release-1.6

[k8s-infra-cherrypick-robot]

@chrischdi: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@chrischdi: new pull request created: #10592

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@chrischdi: #10590 failed to apply on top of branch "release-1.6":

Applying: test: Ensure ownerRef assertions for all Kinds are evaluated
Using index info to reconstruct a base tree...
M	test/framework/ownerreference_helpers.go
Falling back to patching base and 3-way merge...
Auto-merging test/framework/ownerreference_helpers.go
CONFLICT (content): Merge conflict in test/framework/ownerreference_helpers.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test: Ensure ownerRef assertions for all Kinds are evaluated
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.