Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Skip publishing the RemediationRestricted event when there are no unhealthy target #10591

Merged

Conversation

Levi080513
Copy link
Contributor

@Levi080513 Levi080513 commented May 13, 2024

What this PR does / why we need it:

When there are no unhealthy target, skip publishing the RemediationRestricted event to avoid misleading.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #10585

/area machinehealthcheck

@k8s-ci-robot k8s-ci-robot added area/machinehealthcheck Issues or PRs related to machinehealthchecks cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @Levi080513. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 13, 2024
@Levi080513 Levi080513 force-pushed the huangwei/op-mhc-warning-event branch from 5db9173 to ec15add Compare May 13, 2024 06:13
@Levi080513 Levi080513 changed the title Adjust the RemediationRestricted eventType when there are no unhealthy target 🐛: Adjust the RemediationRestricted eventType when there are no unhealty target May 13, 2024
@Levi080513 Levi080513 changed the title 🐛: Adjust the RemediationRestricted eventType when there are no unhealty target 🐛 Adjust the RemediationRestricted eventType when there are no unhealty target May 13, 2024
@Levi080513 Levi080513 force-pushed the huangwei/op-mhc-warning-event branch from ec15add to 65c27b4 Compare May 13, 2024 06:14
@enxebre
Copy link
Member

enxebre commented May 13, 2024

Thanks!
/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 13, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 70a04b05e6a21a1d1751700eab334e4d33fc2410

@Levi080513 Levi080513 force-pushed the huangwei/op-mhc-warning-event branch from 65c27b4 to b973a05 Compare May 14, 2024 05:46
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot k8s-ci-robot requested a review from enxebre May 14, 2024 05:46
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 14, 2024
@Levi080513 Levi080513 force-pushed the huangwei/op-mhc-warning-event branch from b973a05 to 3e589fc Compare May 14, 2024 05:48
@Levi080513 Levi080513 changed the title 🐛 Adjust the RemediationRestricted eventType when there are no unhealty target 🐛 Skip publishing the RemediationRestricted event when there are no unhealthy target May 14, 2024
@sbueringer
Copy link
Member

/lgtm

/assign @enxebre

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a9bcc65450f66e50ee50fe92b710746bf5b2b62f

@enxebre
Copy link
Member

enxebre commented May 15, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit ae8d2d2 into kubernetes-sigs:main May 15, 2024
30 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone May 15, 2024
@Levi080513
Copy link
Contributor Author

Levi080513 commented May 15, 2024

Can this PR cherry pick to 1.6? The main version we are currently using is still 1.6.

@sbueringer
Copy link
Member

Fine for me

@sbueringer
Copy link
Member

/cherry-pick release-1.7

@sbueringer
Copy link
Member

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #10616

In response to this:

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #10617

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Levi080513 Levi080513 deleted the huangwei/op-mhc-warning-event branch May 16, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machinehealthcheck Issues or PRs related to machinehealthchecks cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants