Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.7] 🐛 test: Ensure all ownerRef assertions for some Kind are evaluated #10592

Merged
merged 1 commit into from
May 13, 2024
Merged

[release-1.7] 🐛 test: Ensure all ownerRef assertions for some Kind are evaluated #10592

merged 1 commit into from
May 13, 2024

Commits on May 13, 2024

  1. test: Ensure ownerRef assertions for all Kinds are evaluated 

    The assertFuncs are passed as a list. Previously, if two assertFuncs
were defined for the same Kind, the assertFunc that appeared later
in the list would overwrite the one that appeared earlier.

If someone introduced a second assertFunc for a given Kind, they would
receive no signal that the first assertFunc was overwritten. That would
result in missed assertions.

With this change, if two or more assertFuncs are defined for the same
Kind, both are evaluated.
    @dlipovetsky
    dlipovetsky authored and k8s-infra-cherrypick-robot committed May 13, 2024
    Configuration menu
    Copy the full SHA
    aac1100 View commit details
    Browse the repository at this point in the history