-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Support any controlplane that implements rolloutAfter in it's spec with clusterctl alpha rollout #10648
base: main
Are you sure you want to change the base?
✨ Support any controlplane that implements rolloutAfter in it's spec with clusterctl alpha rollout #10648
Conversation
Hi @wikoion. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
8e5c8ae
to
2c03019
Compare
…plements rolloutAfter in it's spec Signed-off-by: Richard Draycott <wikoion@draycott.live>
2c03019
to
ff0507e
Compare
/ok-to-test |
@wikoion I think you need to run |
27ea695
to
0523c8d
Compare
@wikoion: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Modify clusterctl alpha rollout to support any controlplane.cluster.x-k8s.io and also support different api versions e.g.
clusterctl alpha rollout restart kthreescontrolplane.controlplane.cluster.x-k8s.io.v1beta2/my-kcp
if the version is ommitted then the default ofv1beta1
will be used.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10621
/area clusterctl