Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.6] 🌱 Use kind as a secondary management cluster for clusterctl E2E tests #10676

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
manual cherry-pick of #10639

/area testing

…kubernetes-sigs#10639)

* Use kind as a secondary management cluster for clusterctl E2E tests

* Use kind in all clusterctl tests

* Fix lint

* Address comments
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone May 24, 2024
@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2024
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-release-1-6

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a7f39b6a9c6b3e1ba36e42177ce050aac583c425

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2024
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-mink8s-release-1-6

@k8s-ci-robot k8s-ci-robot merged commit a048fe8 into kubernetes-sigs:release-1.6 May 24, 2024
24 checks passed
@fabriziopandini fabriziopandini deleted the release-1.6-use-kind-for-clusterctl-tests branch June 4, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants