Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.7] 🌱 Improvements to ownerReferences and finalizers test #10747

Merged
merged 2 commits into from
Jun 14, 2024
Merged

[release-1.7] 🌱 Improvements to ownerReferences and finalizers test #10747

merged 2 commits into from
Jun 14, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Backport a subset of changes from main to improvements to ownerReferences and finalizers test (better logging, do not use global expect inside Eventually)

/area e2e-testing

@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2024
sbueringer
sbueringer reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide some context which changes were cherry-picked and which weren't?

E.g. it's not clear to me why this wasn't picked up: https://github.com/kubernetes-sigs/cluster-api/pull/10730/files

In general I would assume we want to get it as much in sync with core CAPI as possible. Although it's not clear to me which parts are not possible (maybe the addition of CoreFinalizersAssertionWithLegacyClusters and the corresponding strict enforcement?)

test/e2e/quick_start_test.go Show resolved Hide resolved
sbueringer
sbueringer reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor finding, otherwise happy to merge

test/framework/finalizers_helpers.go Show resolved Hide resolved
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 14, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

/test pull-cluster-api-e2e-release-1-7

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4aec9f400b6aba235ae2a46e65e463644702cd3f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9cbdc3c into kubernetes-sigs:release-1.7 Jun 14, 2024
22 checks passed
@fabriziopandini fabriziopandini deleted the improvements-to-ownerreference-and-finalizers-test branch June 24, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@sbueringer sbueringer sbueringer left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-testing Issues or PRs related to e2e testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabriziopandini @sbueringer @k8s-ci-robot @chrischdi