-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Ensure unhealthy machines get deletion priority #10755
🌱 Ensure unhealthy machines get deletion priority #10755
Conversation
Thanks! |
LGTM label has been added. Git tree hash: 03466455e30cbdf85b9dd03a1d21b104caf50b68
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Let's please finish the discussion here: #10755 (comment) It might be all good, but the reasoning atm is not correct. |
/cherry-pick release-1.7 |
@vincepri: new pull request created: #10761 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
We recently merged #10712 under the assumption that when deleting machines on older MachineSets, unhealthy machines were prioritized.
This is only true for machines with
NodeHealthy
not set or false, but not for machines withHealthCheckSucceeded
set to false by MHC.This PR fixes this, and thus ongoing rollouts now contribute to a faster remediation of unhealthy machines.
/area machineset
cc @vincepri @enxebre @sbueringer