Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.7] ✨ Add remediation strategy support in MachineDeployment #10759

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Jun 14, 2024

What this PR does / why we need it:

Backport of #10712

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Signed-off-by: Vince Prignano <vince@prigna.com>

tests

Signed-off-by: Vince Prignano <vince@prigna.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 14, 2024
@vincepri vincepri added the area/machinedeployment Issues or PRs related to machinedeployments label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Jun 14, 2024
@vincepri vincepri changed the title ✨ Add remediation strategy support for MachineSet ✨ Add remediation strategy support in MachineDeployment Jun 14, 2024
@vincepri vincepri changed the title ✨ Add remediation strategy support in MachineDeployment [release-1.7] ✨ Add remediation strategy support in MachineDeployment Jun 14, 2024
@vincepri
Copy link
Member Author

/approve

@vincepri
Copy link
Member Author

/assign @sbueringer

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ac70c5ffc2f7236dc1940dddc1d116d575a1a96d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [sbueringer,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 381ef80 into kubernetes-sigs:release-1.7 Jun 14, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machinedeployment Issues or PRs related to machinedeployments cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants