🐛 Patch helper should be able to patch non-spec objects #10824
Conversation
Currently, patch helper is only useful for CRD or any other object that has spec/status fields, where status is considered a subresource. Some types like ConfigMap (and others) don't rely on spec being a top level resource, but instead have other top level fields like `data`. Signed-off-by: Vince Prignano <vince@prigna.com>
k8s-ci-robot
added
cncf-cla: yes
|
/cherry-pick release-1.7 |
k8s-ci-robot
added
the
size/M
|
@vincepri: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ? |
|
@vincepri: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cluster-api-e2e-blocking-main |
|
/test pull-cluster-api-e2e-main |
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f5be72e066fee955ce4ba2118904f9acdcf0b01d
|
|
/cherry-pick release-1.7 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Same flaky test as last time /retest |
|
@sbueringer: new pull request created: #10833 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Currently, patch helper is only useful for CRD or any other object that has spec/status fields, where status is considered a subresource.
Some types like ConfigMap (and others) don't rely on spec being a top level resource, but instead have other top level fields like
data.What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #