Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.7] ✨ Allow CAPBK to generate JoinConfiguration discovery kubeconfig #10842

Merged
merged 2 commits into from
Jul 8, 2024
Merged

[release-1.7] ✨ Allow CAPBK to generate JoinConfiguration discovery kubeconfig #10842

merged 2 commits into from
Jul 8, 2024

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Jul 8, 2024 •
edited by sbueringer

What this PR does / why we need it:
manual cherry-pick of #10799

/area bootstrap

cc @vincepri @sbueringer

@fabriziopandini
Allow CAPBK to generate JoinConfiguration discovery kubeconfig
ef07b7f 
    Signed-off-by: Vince Prignano <vince@prigna.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jul 8, 2024
@k8s-ci-robot k8s-ci-robot added area/bootstrap Issues or PRs related to bootstrap providers cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 8, 2024
@fabriziopandini fabriziopandini added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 8, 2024
@sbueringer
Copy link
Member

/lgtm
/approve

Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b2f9120e70aef4c05ad6a519fb7c31bb2f83adeb

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2024
@sbueringer sbueringer mentioned this pull request Jul 8, 2024
Merged
@k8s-ci-robot k8s-ci-robot merged commit 8dfdece into kubernetes-sigs:release-1.7 Jul 8, 2024
26 checks passed
@fabriziopandini fabriziopandini deleted the release-1.7-cabpk-generate-file-discovery branch July 18, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/bootstrap Issues or PRs related to bootstrap providers cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabriziopandini @sbueringer @k8s-ci-robot