-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Deprecate MachineDeployment revision management #10855
🌱 Deprecate MachineDeployment revision management #10855
Conversation
/assign @fabriziopandini @chrischdi @vincepri @enxebre |
@@ -67,6 +67,8 @@ func NewCmdRolloutUndo(cfgFile string) *cobra.Command { | |||
cmd.Flags().StringVarP(&undoOpt.namespace, "namespace", "n", "", "Namespace where the resource(s) reside. If unspecified, the defult namespace will be used.") | |||
cmd.Flags().Int64Var(&undoOpt.toRevision, "to-revision", undoOpt.toRevision, "The revision to rollback to. Default to 0 (last revision).") | |||
|
|||
cmd.Deprecated = "it will be removed in one of the upcoming releases.\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is logged like this
Command "undo" is deprecated, it will be removed in one of the upcoming releases.
8ba4fb3
to
b1739f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: e5610aa42dfc8d2b8b86bc073bbf57b65f65b779
|
/lgtm @sbueringer thanks for going through deprecations in our backlog, really appreaciated! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer buringerst@vmware.com
b1739f4
to
76ba520
Compare
/lgtm |
LGTM label has been added. Git tree hash: 735856df9f2392bb7ace63b8d2080fa8a6659582
|
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #10479