🌱 Deprecate MachineDeployment revision management #10855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @fabriziopandini @chrischdi @vincepri @enxebre |
k8s-ci-robot
added
the
size/S
sbueringer
commented
Jul 10, 2024
| @@ -67,6 +67,8 @@ func NewCmdRolloutUndo(cfgFile string) *cobra.Command { | |||
| cmd.Flags().StringVarP(&undoOpt.namespace, "namespace", "n", "", "Namespace where the resource(s) reside. If unspecified, the defult namespace will be used.") | |||
| cmd.Flags().Int64Var(&undoOpt.toRevision, "to-revision", undoOpt.toRevision, "The revision to rollback to. Default to 0 (last revision).") | |||
|
|
|||
| cmd.Deprecated = "it will be removed in one of the upcoming releases.\n" | |||
There was a problem hiding this comment.
This is logged like this
Command "undo" is deprecated, it will be removed in one of the upcoming releases.
sbueringer
added
the
area/machinedeployment
51 tasks
sbueringer
force-pushed
the
pr-deprecate-md-revision-mgmt
branch
from
8ba4fb3
to
b1739f4
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: e5610aa42dfc8d2b8b86bc073bbf57b65f65b779
|
|
/lgtm @sbueringer thanks for going through deprecations in our backlog, really appreaciated! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-deprecate-md-revision-mgmt
branch
from
b1739f4
to
76ba520
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 735856df9f2392bb7ace63b8d2080fa8a6659582
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #10479