-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 update Azure quick start for CAPZ v1.16 #10857
Conversation
7acdbac
to
57f3501
Compare
We'd also like to have this in the latest release branch so it's live when we release CAPZ v1.16 next week. No need to wait until before then to merge though. /cherry-pick release-1.7 |
@nojnhuh: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @jackfrancis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 6bf0f1316704c63a4881365d490ca3d7d45a8941
|
Nice, thx! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@nojnhuh: new pull request created: #10859 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This change updates the Azure parts of the quick start guide to account for the default auth mechanism in templates changing to Workload Identity in CAPZ v1.16 (coming next week). These changes add steps to change back to Service Principal auth to avoid turning this doc into yet-another-Workload-Identity-setup doc and to continue to support CAPZ v1.15.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes kubernetes-sigs/cluster-api-provider-azure#4921
/area documentation
/area provider/azure