-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 KubeadmConfig should check on infra ready when there is a ref #10872
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vince Prignano <vince@prigna.com>
/cherry-pick release-1.7 |
@vincepri: once the present PR merges, I will cherry-pick it on top of release-1.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -259,7 +259,7 @@ func (r *KubeadmConfigReconciler) reconcile(ctx context.Context, scope *Scope, c | |||
} | |||
switch { | |||
// Wait for the infrastructure to be ready. | |||
case !cluster.Status.InfrastructureReady: | |||
case cluster.Spec.InfrastructureRef != nil && !cluster.Status.InfrastructureReady: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think with the change I suggested on the other PR this change won't be necessary anymore
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #