✨ Add QPS & burst options & flags for ClusterCacheTracker

[sbueringer]

Signed-off-by: Stefan Büringer buringerst@vmware.com

What this PR does / why we need it:
Before this PR we were using client-go defaults of 5 & 10 qps & burst. This PR changes the defaults to use the same as we use for the mgmt cluster client. It also makes these values configurable to allow fine-tuning at scale.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

/assign @fabriziopandini @chrischdi

[sbueringer]

/test pull-cluster-api-e2e-main

[neolit123]

/lgtm
/hold

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 967378494ff97ec7a2a0aba9173dc7e9fc641309

[chrischdi]

/lgtm

ok for me to cleanup flags as follow-up

[sbueringer]

Let's keep the hold until after the beta tag is created

[neolit123]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2349030491e1e1e769055962df11fa59c7cdc953

[fabriziopandini]

One nit (no strong opinion)
Also, should we use new flags to increase QPS/Burst values in testenv?

[fabriziopandini]

/lgtm
/hold for the release

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 9b380c62de0715a90e66ea3482ddff9cd51e4739

[sbueringer]

/hold cancel

[sbueringer]

(needs approve though @fabriziopandini @chrischdi )

[neolit123]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [neolit123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neolit123]

/meow space

[k8s-ci-robot]

@neolit123:

In response to this:

/meow space

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sivchari]

I interpret that this case will be occurred when the someone specifies ClientQPS or ClientBurst to 0. If it fills out with default value arbitrarily, someone may think the 0 is valid value. So I think this case should return error.

[chrischdi]

Nope, this cases get in two cases:

• when an implementer does not set ClientQPS and/or ClientBurst on the opts ClusterCacheTrackerOptions
• when an implementer sets them, but the user passes in 0 as value

IMHO its fine as is.

[sivchari]

Hi @chrischdi

Thank you for teaching me 👍

when an implementer sets them, but the user passes in 0 as value

I just worried whether it's better that we let implementer know about the information when the actual value of ClientQPS and/or ClientBurst is different from args implementer sets. But I think it is fine too. Thanks.

[sbueringer]

The problem here is that we don't know if someone set the fields explicitly to 0, or they are just 0 because 0 is the "zero value" of these fields.

I don't want to force everyone to set these values, which would happen if we always return an error if the fields are 0

[sivchari]

Hi @sbueringer
I understood it and I agree with your opinion. Surely, this field is option as it is named and it should not force everyone to set these.
Thanks.

[chrischdi]

/retest

[vincepri]

Can we backport this @sbueringer ?

[sbueringer]

Yup

/cherry-pick release-1.7

[k8s-infra-cherrypick-robot]

@sbueringer: #10880 failed to apply on top of branch "release-1.7":

Applying: Add QPS & burst options & flags for ClusterCacheTracker
Using index info to reconstruct a base tree...
M	bootstrap/kubeadm/main.go
M	controllers/remote/cluster_cache_tracker.go
M	controlplane/kubeadm/main.go
A	docs/book/src/developer/providers/migrations/v1.7-to-v1.8.md
M	main.go
M	test/extension/main.go
M	test/infrastructure/docker/main.go
M	test/infrastructure/inmemory/main.go
Falling back to patching base and 3-way merge...
Auto-merging test/infrastructure/inmemory/main.go
Auto-merging test/infrastructure/docker/main.go
Auto-merging test/extension/main.go
Auto-merging main.go
CONFLICT (modify/delete): docs/book/src/developer/providers/migrations/v1.7-to-v1.8.md deleted in HEAD and modified in Add QPS & burst options & flags for ClusterCacheTracker. Version Add QPS & burst options & flags for ClusterCacheTracker of docs/book/src/developer/providers/migrations/v1.7-to-v1.8.md left in tree.
Auto-merging controlplane/kubeadm/main.go
Auto-merging controllers/remote/cluster_cache_tracker.go
Auto-merging bootstrap/kubeadm/main.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add QPS & burst options & flags for ClusterCacheTracker
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Yup

/cherry-pick release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[sbueringer]

If you open a cherry-pick PR 😀