-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 book: document how to use Lima on macOS for development #11119
Conversation
Thank you very much! /lgtm /assign @fabriziopandini |
LGTM label has been added. Git tree hash: c5d2d0b150ae4002544a4ba701066a7ec2089748
|
58ee4cc
to
7803aaa
Compare
missed to add 1 parameter :-) |
/lgtm |
LGTM label has been added. Git tree hash: c24ca8c8e72326dd3060a7c87c72bd398919043d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I was wondering if there is a place with higher visibility then the clusterctl documentation
I think I would prefer moving it after https://cluster-api.sigs.k8s.io/developer/tilt.html?highlight=docker#using-podman (but I also don't have strong preferences on what is the best location)
Additionally, we should probably quote that lima is a viable option in a few places
7803aaa
to
55c3456
Compare
55c3456
to
c5d2083
Compare
Added at the first two places. At the end it is still docker which is provided via lima so it felt a bit wrong to me at the quick-start level. But I can adjust there too if you want to. |
/lgtm |
LGTM label has been added. Git tree hash: 72d5a087f916f034c4c5df1c32977996ecff53d4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nits from my side
c5d2083
to
b6388b3
Compare
/lgtm /cherry-pick release-1.8 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
LGTM label has been added. Git tree hash: a37d0ba3ec89310e8d4f07b7680cddfd86c9e135
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@fabriziopandini: new pull request created: #11139 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
I'm using this setup for a while now and did not hit any issues. It is even more stable for me compared to docker desktop on OSX.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area documentation