Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Improve unit tests for Machine controller #11252

Merged
merged 1 commit into from
Oct 8, 2024
Merged

🌱 Improve unit tests for Machine controller #11252

merged 1 commit into from
Oct 8, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Improving unit test coverage on reconcileBootstrap and reconcileInfrastructure in the Machine controller

/area machine

/hold for discussing a few test cases

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 4, 2024
@fabriziopandini
Copy link
Member Author

cc @sbueringer @chrischdi @enxebre @vincepri
PTAL my comments about current behaviours in Machine controller's reconcileBootstrap and reconcileInfrastructure that I would like to double check with you

@chrischdi
Copy link
Member

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-blocking-main
  • /test pull-cluster-api-e2e-conformance-ci-latest-main
  • /test pull-cluster-api-e2e-conformance-main
  • /test pull-cluster-api-e2e-latestk8s-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-upgrade-1-31-1-32-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-blocking-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member

/lgtm
/test pull-cluster-api-e2e-main

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2a15cda2c46ecf4b8e3622d58731c0e2fe190378

sbueringer
sbueringer reviewed Oct 8, 2024
View reviewed changes
internal/controllers/machine/machine_controller_noderef_test.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_noderef_test.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_phases.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_phases.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_phases.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_phases.go Show resolved Hide resolved
internal/controllers/machine/machine_controller_phases_test.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_phases_test.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_phases_test.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_phases_test.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@fabriziopandini fabriziopandini force-pushed the improve-machine-controller-unit-tests branch from 104d704 to 768d13a Compare October 8, 2024 13:02
sbueringer
sbueringer reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very last one

internal/controllers/machine/machine_controller_phases_test.go Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the improve-machine-controller-unit-tests branch from 768d13a to e678f88 Compare October 8, 2024 15:22
@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2024
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ec947b815a04471537d3728fd22d6a6bbea87fe0

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 48ee02a into kubernetes-sigs:main Oct 8, 2024
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 8, 2024
@sbueringer sbueringer mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri left review comments

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@fabriziopandini @chrischdi @k8s-ci-robot @sbueringer @vincepri