Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add v1beta2 Etcd and ControlPlaneComponents conditions to KCP #11302

Merged
merged 1 commit into from
Oct 21, 2024
Merged

✨ Add v1beta2 Etcd and ControlPlaneComponents conditions to KCP #11302

merged 1 commit into from
Oct 21, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR adds code for updating v1beta2 status Etcd and ControlPlaneComponents conditions set by KCP on machines.

Which issue(s) this PR fixes:
Rif #11105

/area kubeadmcontrolplane

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/kubeadmcontrolplane cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
This PR adds code for updating v1beta2 status Etcd and ControlPlaneComponents conditions set by KCP on machines.

Which issue(s) this PR fixes:
Rif #11105

/area kubeadmcontrolplane

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Oct 17, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 17, 2024
@fabriziopandini fabriziopandini mentioned this pull request Oct 17, 2024
Closed
59 tasks
@sbueringer sbueringer added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Oct 18, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Oct 18, 2024
sbueringer
sbueringer reviewed Oct 18, 2024
View reviewed changes
docs/proposals/20240916-improve-status-in-CAPI-resources.md Outdated Show resolved Hide resolved
docs/proposals/20240916-improve-status-in-CAPI-resources.md Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2024
@fabriziopandini fabriziopandini force-pushed the add-v1beta2-etcd-and-controlplane-conditions-to-KCP branch from b7dc24c to 138857c Compare October 21, 2024 11:06
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2024
sbueringer
sbueringer reviewed Oct 21, 2024
View reviewed changes
controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions_test.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions_test.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions_test.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions_test.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions_test.go Show resolved Hide resolved
controlplane/kubeadm/internal/workload_cluster_conditions_test.go Show resolved Hide resolved
@sbueringer
Copy link
Member

@fabriziopandini Just a few smaller findings + #11302 (comment)

@sbueringer
Copy link
Member

Thx!

/lgtm
/approve

/hold
Feel free to squash / merge / whatever :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e15a619a1e224f9ada28bc2ba7dd0f9d51c691d2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@fabriziopandini
Add v1beta2 Etcd and ControlPlaneComponents conditions to KCP
94ebc1f 
# Conflicts:
#	controlplane/kubeadm/api/v1beta1/v1beta2_condition_consts.go
@fabriziopandini fabriziopandini force-pushed the add-v1beta2-etcd-and-controlplane-conditions-to-KCP branch from 32a6406 to 94ebc1f Compare October 21, 2024 16:31
@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 94ebc1f link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit d357a2f into kubernetes-sigs:main Oct 21, 2024
16 of 17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Oct 21, 2024
@fabriziopandini fabriziopandini deleted the add-v1beta2-etcd-and-controlplane-conditions-to-KCP branch November 13, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@fabriziopandini @k8s-ci-robot @sbueringer