Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.8] 🌱 Cache DiscoveryVariables calls #11600

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[release-1.8] 🌱 Cache DiscoveryVariables calls #11600

merged 2 commits into from
Dec 20, 2024

Conversation

chrischdi
Copy link
Member

Manual cherry-pick of

also had to cherry-pick the internal/util/cache introduced in v1.9

/hold
/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Dec 20, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 20, 2024
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-main

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-8
  • /test pull-cluster-api-e2e-blocking-release-1-8
  • /test pull-cluster-api-e2e-conformance-ci-latest-release-1-8
  • /test pull-cluster-api-e2e-conformance-release-1-8
  • /test pull-cluster-api-e2e-mink8s-release-1-8
  • /test pull-cluster-api-e2e-release-1-8
  • /test pull-cluster-api-e2e-upgrade-1-30-1-31-release-1-8
  • /test pull-cluster-api-test-mink8s-release-1-8
  • /test pull-cluster-api-test-release-1-8
  • /test pull-cluster-api-verify-release-1-8

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-8

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-8
  • pull-cluster-api-build-release-1-8
  • pull-cluster-api-e2e-blocking-release-1-8
  • pull-cluster-api-test-release-1-8
  • pull-cluster-api-verify-release-1-8

In response to this:

/test pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chrischdi
Copy link
Member Author

/tide merge-method-squash

@chrischdi
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 20, 2024
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-release-1-8

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 657d4bf8327ce8e32b3bbb7bef1ac02cbce4a633

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2024
@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0b3fda4 into kubernetes-sigs:release-1.8 Dec 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @k8s-ci-robot @sbueringer @fabriziopandini