Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-0.1: kustomization.yaml: Use patchesStrategicMerge (#1184) #1185

Merged

Conversation

russellb
Copy link
Contributor

A previous release of kustomize deprecated "patches:" and the latest
version (v3.0.3) will fail on it. Replacing this with
"patchesStrategicMerge:" should make this kustomization.yaml continue
to work across kustomize versions.

(cherry picked from commit 8d4cb92)

A previous release of kustomize deprecated "patches:" and the latest
version (v3.0.3) will fail on it.  Replacing this with
"patchesStrategicMerge:" should make this kustomization.yaml continue
to work across kustomize versions.

(cherry picked from commit 8d4cb92)
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 23, 2019
@vincepri
Copy link
Member

/approve
/assign @detiber

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: russellb, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@ncdc
Copy link
Contributor

ncdc commented Jul 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit dab3fe9 into kubernetes-sigs:release-0.1 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants