-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.1] set OwnerRef in more cases #1207
Conversation
0b096a2
to
b918159
Compare
/assign @ncdc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm, some minor nits around the logging output
pkg/controller/machinedeployment/machinedeployment_controller.go
Outdated
Show resolved
Hide resolved
/test pull-cluster-api-test pull-cluster-api-integration |
/test pull-cluster-api-test |
Tagging as Liz is out of the office and my only comment is a typo we can fix in a follow-up. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liztio, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Right now the cluster manager will only set an ownerreference if no owner exists at creation time. This could potentially cause issues if an object is owned by a not-Cluster API object. Instead, we will check all references to see if they point to a cluster-api object, and "adopt" them if they do not.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1190
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: