-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Doc for updating v1a1 provider to v1a2 #1244
📖 Doc for updating v1a1 provider to v1a2 #1244
Conversation
/kind documentation |
docs/developer/update-v1alpha1-provider-to-v1alpha2-infra-provider.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for starting on this, picked some nits related to terminology and some other minor comments.
docs/developer/update-v1alpha1-provider-to-v1alpha2-infra-provider.md
Outdated
Show resolved
Hide resolved
docs/developer/update-v1alpha1-provider-to-v1alpha2-infra-provider.md
Outdated
Show resolved
Hide resolved
docs/developer/update-v1alpha1-provider-to-v1alpha2-infra-provider.md
Outdated
Show resolved
Hide resolved
docs/developer/update-v1alpha1-provider-to-v1alpha2-infra-provider.md
Outdated
Show resolved
Hide resolved
docs/developer/update-v1alpha1-provider-to-v1alpha2-infra-provider.md
Outdated
Show resolved
Hide resolved
docs/developer/update-v1alpha1-provider-to-v1alpha2-infra-provider.md
Outdated
Show resolved
Hide resolved
docs/developer/update-v1alpha1-provider-to-v1alpha2-infra-provider.md
Outdated
Show resolved
Hide resolved
@akutz I would like to help with this migration for CAPV. The first item is creating branches in the repo as detailed. I am afraid I will not have the needed permissions to do so. Please let me know if I can take it up. |
docs/developer/update-v1alpha1-provider-to-v1alpha2-infra-provider.md
Outdated
Show resolved
Hide resolved
@akutz are you still interested & would you have time to port this over to the book content? |
Hi @ncdc, Yes sir, I just haven't had time. I've got to prep for something this morning, but I should be able to address this before the end of the week. |
Fantastic, thank you! |
@akutz Will you have time to address the comments and port the content to the book? |
@akutz Do you have time to address the comments? |
a3c9afc
to
d2b122b
Compare
d2b122b
to
1e47752
Compare
I've addressed the feedback, but now I wonder the following:
Thanks! |
I would keep it in |
Or we could just do this in |
1e47752
to
7cf4eb0
Compare
Hi @ncdc, I merged the two developer docs into the requested location. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. This is a very streamlined version of the process we went through to get here.
One addition that might be nice to have but not necessary are moving to kubebuilder v2 as mentioned to in the intro, but that's a fairly invasive upgrade iirc, so it's definitely fine to omit.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akutz, chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @chuckha, I'm happy to add something about kubebuilder v2, but I'm wondering what you're thinking that isn't part of the kubebuilder section already? |
Kubebuilder went through a lot of changes with the Makefile, main.go, directory structure. But that's actually all covered in the kubebuilder book! Maybe we should add a link out to this: https://book.kubebuilder.io/migration/v1vsv2.html and leave it at that? What do you think? |
Ah, I see. Yes, that sounds good. I'll make a note that if you move to kubebuilder v2, the changes are more than just code-based, and that a full review of the aforementioned link is a good idea. |
This patch includes developer documentation to assist with updating a v1alpha1 provider to v1alpha2.
7cf4eb0
to
f952719
Compare
Hi @chuckha, Done and done. Thank you for the suggestion. |
/assign @ncdc for last review |
/lgtm |
What this PR does / why we need it:
This patch includes developer documentation to assist with updating a v1alpha1 provider to v1alpha2.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: