Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Doc for updating v1a1 provider to v1a2 #1244

Conversation

akutz
Copy link
Contributor

@akutz akutz commented Aug 12, 2019

What this PR does / why we need it:
This patch includes developer documentation to assist with updating a v1alpha1 provider to v1alpha2.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

* Developer documentation for updating a v1alpha1 provider to v1alpha2

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 12, 2019
@akutz
Copy link
Contributor Author

akutz commented Aug 12, 2019

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 12, 2019
Copy link
Member

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting on this, picked some nits related to terminology and some other minor comments.

@akutz
Copy link
Contributor Author

akutz commented Aug 12, 2019

Thanks for starting on this, picked some nits related to terminology and some other minor comments.

Hi @detiber,

You're welcome. After @ncdc so generously walked me through v1alpha2, I figured I should pay it forward and write things down before I forget.

@ykakarap
Copy link
Contributor

ykakarap commented Aug 14, 2019

@akutz I would like to help with this migration for CAPV.

The first item is creating branches in the repo as detailed. I am afraid I will not have the needed permissions to do so.
Therefore I would like to start working on the second item: creating the provider's v1alpha2 resources.

Please let me know if I can take it up.

@detiber detiber added this to the v0.2.x (v1alpha2) milestone Aug 29, 2019
@ncdc
Copy link
Contributor

ncdc commented Sep 11, 2019

@akutz are you still interested & would you have time to port this over to the book content?

@akutz
Copy link
Contributor Author

akutz commented Sep 11, 2019

Hi @ncdc,

Yes sir, I just haven't had time. I've got to prep for something this morning, but I should be able to address this before the end of the week.

@ncdc
Copy link
Contributor

ncdc commented Sep 11, 2019

Fantastic, thank you!

@ncdc ncdc changed the title Doc for updating v1a1 provider to v1a2 📖 Doc for updating v1a1 provider to v1a2 Sep 11, 2019
@vincepri
Copy link
Member

@akutz Will you have time to address the comments and port the content to the book?

@akutz akutz changed the base branch from master to release-0.2 October 10, 2019 20:49
@vincepri
Copy link
Member

@akutz Do you have time to address the comments?

@akutz akutz force-pushed the feature/update-provider-to-v1alpha2-docs branch from a3c9afc to d2b122b Compare November 12, 2019 22:14
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2019
@akutz akutz force-pushed the feature/update-provider-to-v1alpha2-docs branch from d2b122b to 1e47752 Compare November 12, 2019 22:15
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 12, 2019
@akutz
Copy link
Contributor Author

akutz commented Nov 12, 2019

Hi @ncdc & @detiber,

I've addressed the feedback, but now I wonder the following:

  1. Should this be added to the CAPI book? If so, where? @vincepri indicated there is a developer page, but it's more about getting started with the project as a developer, and less about what this document is attempting to capture.
  2. Should I retarget this at master? It may be good to have for the historical record. It could also be closed as it's largely no longer relevant. It's up to y'all. It's my fault I took so long with this.

Thanks!

@ncdc
Copy link
Contributor

ncdc commented Nov 13, 2019

I would keep it in master, move it perhaps into docs/book/src/providers/v1alpha1-to-v1alpha2.md, and also backport to release-0.2.

@ncdc
Copy link
Contributor

ncdc commented Nov 13, 2019

Or we could just do this in release-0.2 if that's preferable.

@akutz akutz force-pushed the feature/update-provider-to-v1alpha2-docs branch from 1e47752 to 7cf4eb0 Compare November 13, 2019 18:14
@akutz
Copy link
Contributor Author

akutz commented Nov 13, 2019

Hi @ncdc,

I merged the two developer docs into the requested location.

@ncdc
Copy link
Contributor

ncdc commented Nov 13, 2019

Thanks @akutz!

/assign @chuckha
as he wrote the initial doc

Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. This is a very streamlined version of the process we went through to get here.

One addition that might be nice to have but not necessary are moving to kubebuilder v2 as mentioned to in the intro, but that's a fairly invasive upgrade iirc, so it's definitely fine to omit.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akutz, chuckha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@akutz
Copy link
Contributor Author

akutz commented Nov 13, 2019

Hi @chuckha,

I'm happy to add something about kubebuilder v2, but I'm wondering what you're thinking that isn't part of the kubebuilder section already?

@chuckha
Copy link
Contributor

chuckha commented Nov 13, 2019

Kubebuilder went through a lot of changes with the Makefile, main.go, directory structure. But that's actually all covered in the kubebuilder book! Maybe we should add a link out to this: https://book.kubebuilder.io/migration/v1vsv2.html and leave it at that? What do you think?

@akutz
Copy link
Contributor Author

akutz commented Nov 13, 2019

Ah, I see. Yes, that sounds good. I'll make a note that if you move to kubebuilder v2, the changes are more than just code-based, and that a full review of the aforementioned link is a good idea.

This patch includes developer documentation to assist with updating a
v1alpha1 provider to v1alpha2.
@akutz akutz force-pushed the feature/update-provider-to-v1alpha2-docs branch from 7cf4eb0 to f952719 Compare November 13, 2019 22:37
@akutz
Copy link
Contributor Author

akutz commented Nov 13, 2019

Hi @chuckha,

Done and done. Thank you for the suggestion.

@chuckha
Copy link
Contributor

chuckha commented Nov 14, 2019

/assign @ncdc

for last review

@ncdc
Copy link
Contributor

ncdc commented Nov 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 755795f into kubernetes-sigs:release-0.2 Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants