⚠️ [0.1] Cluster, machine controller: support concurrency #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
added
the
priority/important-longterm
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
ncdc
changed the title
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
k8s-ci-robot
added
size/M
k8s-ci-robot
added
the
lgtm
|
@ncdc are you planning on adding support for MachineSet/MachineDeployment controllers in a separate PR? |
|
@detiber see what I wrote above in the description |
|
Do you want me to do MS & MD too? |
|
I'm good with skipping MS & MD for now |
|
@ncdc Can you open a tracking issue about it? So we won't forget later |
|
@vincepri I'm doing a PR for master that will cover all the controllers. I can open a 0.1 issues for MS & MD |
This was referenced Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow the concurrency to be configurable for the cluster and machine controllers. This is a breaking change to the
AddWithActuatorfunctions, but it's minor (the addition of a newconcurrencyparameter). Providers will need to adjust their managermain.gofiles accordingly (ideally by adding flags to control the concurrency).I have not dealt with the MachineSet and MachineDeployment controllers in this PR because that requires some more surgery - we'd essentially need to remove the
init()-basedAddToManagerFuncsapproach to make that happen. If there is interest, I can do it, but I think reconciling MachineSets and MachineDeployments one by one is probably ok for now, given that each iteration should be fast compared to single-threading cluster & machine.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #