-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ [0.1] Cluster, machine controller: support concurrency #1302
⚠️ [0.1] Cluster, machine controller: support concurrency #1302
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@ncdc are you planning on adding support for MachineSet/MachineDeployment controllers in a separate PR? |
@detiber see what I wrote above in the description |
Do you want me to do MS & MD too? |
I'm good with skipping MS & MD for now |
@ncdc Can you open a tracking issue about it? So we won't forget later |
@vincepri I'm doing a PR for master that will cover all the controllers. I can open a 0.1 issues for MS & MD |
What this PR does / why we need it:
Allow the concurrency to be configurable for the cluster and machine controllers. This is a breaking change to the
AddWithActuator
functions, but it's minor (the addition of a newconcurrency
parameter). Providers will need to adjust their managermain.go
files accordingly (ideally by adding flags to control the concurrency).I have not dealt with the MachineSet and MachineDeployment controllers in this PR because that requires some more surgery - we'd essentially need to remove the
init()
-basedAddToManagerFuncs
approach to make that happen. If there is interest, I can do it, but I think reconciling MachineSets and MachineDeployments one by one is probably ok for now, given that each iteration should be fast compared to single-threading cluster & machine.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #