🐛 track MS with old labels after updating MD labels #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
tahsinrahman
changed the title
|
cc @sethp-nr |
k8s-ci-robot
added
size/L
|
/test pull-cluster-api-test |
ncdc
reviewed
Sep 3, 2019
tahsinrahman
force-pushed
the
track-old-ms
branch
from
9a7eeb4
to
620f3ea
Compare
|
/test pull-cluster-api-test |
tahsinrahman
force-pushed
the
track-old-ms
branch
2 times, most recently
from
ef8510f
to
4e55f58
Compare
|
/test pull-cluster-api-test |
1 similar comment
|
/test pull-cluster-api-test |
ncdc
reviewed
Sep 4, 2019
tahsinrahman
force-pushed
the
track-old-ms
branch
from
4e55f58
to
4d2553e
Compare
tahsinrahman
force-pushed
the
track-old-ms
branch
from
4d2553e
to
bfd65df
Compare
liztio
approved these changes
Sep 6, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ncdc, tahsinrahman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Great work @tahsinrahman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1341